[CVE-2024-33273] Improper neutralization of SQL parameter in ShipUp module for PrestaShop

PrestaShop Security Advisory

In the module “ShipUp” (shipup) up to version 3.3.0 from ShipUp for PrestaShop, a guest can perform SQL injection in affected versions.

Summary

  • CVE ID: CVE-2024-33273
  • Published at: 2024-04-29
  • Platform: PrestaShop
  • Product: shipup
  • Impacted release: < 3.3.0 (3.3.0 fixed the vulnerability)
  • Product author: ShipUp
  • Weakness: CWE-89
  • Severity: critical (9.8)

Description

The function getShopId has sensitive a SQL call that can be executed with a trivial http call and exploited to forge a SQL injection.

Be informed that it only concerns Shops which never own more than one store.

Note : We marked that 3.3.0 fixed the vulnerability because it fixes the critical one, but you should apply the 3.5.0 which fix another high vulnerability with a CVSS score 3.1 of 7.1/10.

CVSS base metrics

  • Attack vector: network
  • Attack complexity: low
  • Privilege required: none
  • User interaction: none
  • Scope: unchanged
  • Confidentiality: high
  • Integrity: high
  • Availability: high

Vector string: CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H

Possible malicious usage

  • Obtain admin access
  • Remove data from the associated PrestaShop
  • Copy/paste data from sensitive tables to FRONT to expose tokens and unlock admin’s ajax scripts
  • Rewrite SMTP settings to hijack emails

Patch from 3.1.0

--- 3.1.0/modules/shipup/v1/index.php
+++ 3.5.0/modules/shipup/v1/index.php
...
@@ -30,14 +30,14 @@ function getShopId()
         if (!isset($_GET['shop_id'])) {
             render(403, 'Multi store present but no store_id provided');
         } else {
-            $query = $query." WHERE `id_shop` = '".$_GET['shop_id']."'";
+            $query = $query." WHERE `id_shop` = '". (int) $_GET['shop_id']."'";
         }
     }
     $shop_id = (int)($db->getValue($query));
     if ($shop_id == '') {
         if (isset($_GET['shop_id'])) {
-            $msg = "Store shop_id ".$_GET['shop_id']." not found";
+            $msg = "Store shop_id ".(int) $_GET['shop_id']." not found";
         } else {
             $msg = 'Store not found';
         }
@@ -211,7 +211,7 @@ function select_limit_10($table, $param,
     $where_clause = "";
     if (isset($_GET[$param])) {
         if (isset($_GET['exact'])) {
-            $where_clause = "WHERE `".$param."` = ".$db->escape($_GET[$param]);
+            $where_clause = "WHERE `".$param."` = ".(int) $_GET[$param];
         } else {
             $where_clause = "WHERE `".$param."` LIKE '%".$db->escape($_GET[$param])."%'";
         }
...

Other recommendations

  • It’s recommended to upgrade to the latest version of the module shipup.
  • To help improve the security of your PrestaShop installation, we recommend upgrading to the latest version. One of the benefits of upgrading is that it will disable the use of multiquery executions (separated by semicolons). However, please be aware that this will not protect your shop against SQL injection attacks that use the UNION clause to steal data. Additionally, it’s important to note that PrestaShop includes a function called pSQL, which includes a strip_tags function. This helps protect your shop against Stored XSS (also known as XSS T2) of Category 1. If a pSQL function is missing, it could potentially expose your project to critical Stored XSS vulnerabilities due to edge cases. Therefore, it’s crucial to ensure that all relevant functions are properly implemented and used consistently throughout your project.
  • Change the default database prefix ps_ with a new longer, arbitrary prefix. Nevertheless, be warned that this is useless against blackhats with DBA senior skills because of a design vulnerability in DBMS
  • Activate OWASP 942’s rules on your WAF (Web application firewall), be warned that you will probably break your backoffice and you will need to pre-configure some bypasses against this set of rules.

Timeline

DateAction
2024-03-13Issue discovered during a code review by TouchWeb.fr
2024-03-13Contact Author to confirm version scope by author
2024-03-14Author confirms version scope
2024-04-23Received CVE ID
2024-04-29Publish this security advisory

READ MORE

Leave a Reply

Your email address will not be published. Required fields are marked *